Commit efc52055 authored by Maxime Chevallier's avatar Maxime Chevallier Committed by David S. Miller
Browse files

net: freescale: ucc_geth: Move the serdes configuration around 



The uec_configure_serdes() function deals with serialized linkmodes
settings. It's used during the link bringup sequence. It is planned to
be used during the phylink conversion for mac configuration, but it
needs to me moved around in the process. To make the phylink port
clearer, this commit moves the function without any feature change.

Signed-off-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dba25f75

drivers/net/ethernet/freescale/ucc_geth.c

+46 −47
Original line number Diff line number Diff line
@@ -1512,6 +1512,52 @@ static void ugeth_activate(struct ucc_geth_private *ugeth) 
	__netdev_watchdog_up(ugeth->ndev);

}



/* Initialize TBI PHY interface for communicating with the

 * SERDES lynx PHY on the chip.  We communicate with this PHY

 * through the MDIO bus on each controller, treating it as a

 * "normal" PHY at the address found in the UTBIPA register.  We assume

 * that the UTBIPA register is valid.  Either the MDIO bus code will set

 * it to a value that doesn't conflict with other PHYs on the bus, or the

 * value doesn't matter, as there are no other PHYs on the bus.

 */

static void uec_configure_serdes(struct net_device *dev)

{

	struct ucc_geth_private *ugeth = netdev_priv(dev);

	struct ucc_geth_info *ug_info = ugeth->ug_info;

	struct phy_device *tbiphy;



	if (!ug_info->tbi_node) {

		dev_warn(&dev->dev, "SGMII mode requires that the device tree specify a tbi-handle\n");

		return;

	}



	tbiphy = of_phy_find_device(ug_info->tbi_node);

	if (!tbiphy) {

		dev_err(&dev->dev, "error: Could not get TBI device\n");

		return;

	}



	/*

	 * If the link is already up, we must already be ok, and don't need to

	 * configure and reset the TBI<->SerDes link.  Maybe U-Boot configured

	 * everything for us?  Resetting it takes the link down and requires

	 * several seconds for it to come back.

	 */

	if (phy_read(tbiphy, ENET_TBI_MII_SR) & TBISR_LSTATUS) {

		put_device(&tbiphy->mdio.dev);

		return;

	}



	/* Single clk mode, mii mode off(for serdes communication) */

	phy_write(tbiphy, ENET_TBI_MII_ANA, TBIANA_SETTINGS);



	phy_write(tbiphy, ENET_TBI_MII_TBICON, TBICON_CLK_SELECT);



	phy_write(tbiphy, ENET_TBI_MII_CR, TBICR_SETTINGS);



	put_device(&tbiphy->mdio.dev);

}



static void ugeth_link_up(struct ucc_geth_private *ugeth,

			  struct phy_device *phy,

			  phy_interface_t interface, int speed, int duplex)
@@ -1619,53 +1665,6 @@ static void adjust_link(struct net_device *dev) 
		ugeth_link_down(ugeth);

}



/* Initialize TBI PHY interface for communicating with the

 * SERDES lynx PHY on the chip.  We communicate with this PHY

 * through the MDIO bus on each controller, treating it as a

 * "normal" PHY at the address found in the UTBIPA register.  We assume

 * that the UTBIPA register is valid.  Either the MDIO bus code will set

 * it to a value that doesn't conflict with other PHYs on the bus, or the

 * value doesn't matter, as there are no other PHYs on the bus.

 */

static void uec_configure_serdes(struct net_device *dev)

{

	struct ucc_geth_private *ugeth = netdev_priv(dev);

	struct ucc_geth_info *ug_info = ugeth->ug_info;

	struct phy_device *tbiphy;



	if (!ug_info->tbi_node) {

		dev_warn(&dev->dev, "SGMII mode requires that the device "

			"tree specify a tbi-handle\n");

		return;

	}



	tbiphy = of_phy_find_device(ug_info->tbi_node);

	if (!tbiphy) {

		dev_err(&dev->dev, "error: Could not get TBI device\n");

		return;

	}



	/*

	 * If the link is already up, we must already be ok, and don't need to

	 * configure and reset the TBI<->SerDes link.  Maybe U-Boot configured

	 * everything for us?  Resetting it takes the link down and requires

	 * several seconds for it to come back.

	 */

	if (phy_read(tbiphy, ENET_TBI_MII_SR) & TBISR_LSTATUS) {

		put_device(&tbiphy->mdio.dev);

		return;

	}



	/* Single clk mode, mii mode off(for serdes communication) */

	phy_write(tbiphy, ENET_TBI_MII_ANA, TBIANA_SETTINGS);



	phy_write(tbiphy, ENET_TBI_MII_TBICON, TBICON_CLK_SELECT);



	phy_write(tbiphy, ENET_TBI_MII_CR, TBICR_SETTINGS);



	put_device(&tbiphy->mdio.dev);

}



/* Configure the PHY for dev.

 * returns 0 if success.  -1 if failure

 */