Commit efdddc44 authored by Álvaro Fernández Rojas's avatar Álvaro Fernández Rojas Committed by Jakub Kicinski
Browse files

net: dsa: tag_brcm: legacy: fix pskb_may_pull length 



BRCM_LEG_PORT_ID was incorrectly used for pskb_may_pull length.
The correct check is BRCM_LEG_TAG_LEN + VLAN_HLEN, or 10 bytes.

Fixes: 964dbf18 ("net: dsa: tag_brcm: add support for legacy tags")
Signed-off-by: default avatarÁlvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250529124406.2513779-1-noltari@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d1a866d5

net/dsa/tag_brcm.c

+1 −1
Original line number Diff line number Diff line
@@ -257,7 +257,7 @@ static struct sk_buff *brcm_leg_tag_rcv(struct sk_buff *skb, 
	int source_port;

	u8 *brcm_tag;



	if (unlikely(!pskb_may_pull(skb, BRCM_LEG_PORT_ID)))

	if (unlikely(!pskb_may_pull(skb, BRCM_LEG_TAG_LEN + VLAN_HLEN)))

		return NULL;



	brcm_tag = dsa_etype_header_pos_rx(skb);