Unverified Commit f02d3bfc authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/tests: modes: Fix drm_display_mode memory leak 



drm_analog_tv_mode() and its variants return a drm_display_mode that
needs to be destroyed later one. The
drm_test_modes_analog_tv_mono_576i() test never does however, which
leads to a memory leak.

Let's make sure it's freed.

Reported-by: default avatarPhilipp Stanner <phasta@mailbox.org>
Closes: https://lore.kernel.org/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.camel@mailbox.org/


Fixes: e3153848 ("drm/tests: Add tests for the new Monochrome value of tv_mode")
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250408-drm-kunit-drm-display-mode-memleak-v1-6-996305a2e75a@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent d3414634

drivers/gpu/drm/tests/drm_modes_test.c

+4 −0
Original line number Diff line number Diff line
@@ -156,6 +156,7 @@ static void drm_test_modes_analog_tv_mono_576i(struct kunit *test) 
{

	struct drm_test_modes_priv *priv = test->priv;

	struct drm_display_mode *mode;

	int ret;



	mode = drm_analog_tv_mode(priv->drm,

				  DRM_MODE_TV_MODE_MONOCHROME,
@@ -163,6 +164,9 @@ static void drm_test_modes_analog_tv_mono_576i(struct kunit *test) 
				  true);

	KUNIT_ASSERT_NOT_NULL(test, mode);



	ret = drm_kunit_add_mode_destroy_action(test, mode);

	KUNIT_ASSERT_EQ(test, ret, 0);



	KUNIT_EXPECT_EQ(test, drm_mode_vrefresh(mode), 50);

	KUNIT_EXPECT_EQ(test, mode->hdisplay, 720);