Commit f052f62c authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

tty/vt: consolemap: remove glyph < 0 check from set_inverse_trans_unicode() 



glyph is now an int casted from u16. It can never be negative. So remove
the check and type glyph as u16 properly in set_inverse_trans_unicode().

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220607104946.18710-18-jslaby@suse.cz


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5a904a93

drivers/tty/vt/consolemap.c

+3 −4
Original line number Diff line number Diff line
@@ -244,7 +244,7 @@ static void set_inverse_transl(struct vc_data *conp, struct uni_pagedict *p, 
static void set_inverse_trans_unicode(struct vc_data *conp,

				      struct uni_pagedict *p)

{

	int i, j, k, glyph;

	int i, j, k;

	u16 **p1, *p2;

	u16 *q;
@@ -268,9 +268,8 @@ static void set_inverse_trans_unicode(struct vc_data *conp, 
			if (!p2)

				continue;

			for (k = 0; k < UNI_ROW_GLYPHS; k++) {

				glyph = p2[k];

				if (glyph >= 0 && glyph < MAX_GLYPH

					       && q[glyph] < 32)

				u16 glyph = p2[k];

				if (glyph < MAX_GLYPH && q[glyph] < 32)

					q[glyph] = UNI(i, j, k);

			}

		}