Commit f063ac6b authored by Jessica Zhang's avatar Jessica Zhang Committed by Abhinav Kumar
Browse files

drm/msm/dpu: Disable dither in phys encoder cleanup 



Disable pingpong dither in dpu_encoder_helper_phys_cleanup().

This avoids the issue where an encoder unknowingly uses dither after
reserving a pingpong block that was previously bound to an encoder that
had enabled dither.

Cc: stable@vger.kernel.org
Reported-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Closes: https://lore.kernel.org/all/jr7zbj5w7iq4apg3gofuvcwf4r2swzqjk7sshwcdjll4mn6ctt@l2n3qfpujg3q/


Signed-off-by: default avatarJessica Zhang <quic_jesszhan@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Fixes: 3c128638 ("drm/msm/dpu: add support for dither block in display")
Patchwork: https://patchwork.freedesktop.org/patch/636517/
Link: https://lore.kernel.org/r/20250211-dither-disable-v1-1-ac2cb455f6b9@quicinc.com


Signed-off-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
parent 978ca99d

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

+3 −0
Original line number Diff line number Diff line
@@ -2281,6 +2281,9 @@ void dpu_encoder_helper_phys_cleanup(struct dpu_encoder_phys *phys_enc) 
		}

	}



	if (phys_enc->hw_pp && phys_enc->hw_pp->ops.setup_dither)

		phys_enc->hw_pp->ops.setup_dither(phys_enc->hw_pp, NULL);



	/* reset the merge 3D HW block */

	if (phys_enc->hw_pp && phys_enc->hw_pp->merge_3d) {

		phys_enc->hw_pp->merge_3d->ops.setup_3d_mode(phys_enc->hw_pp->merge_3d,