Commit f0672505 authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Carlos Maiolino
Browse files

xfs: fix stupid compiler warning 



gcc 14.2 warns about:

xfs_attr_item.c: In function ‘xfs_attr_recover_work’:
xfs_attr_item.c:785:9: warning: ‘ip’ may be used uninitialized [-Wmaybe-uninitialized]
  785 |         xfs_trans_ijoin(tp, ip, 0);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
xfs_attr_item.c:740:42: note: ‘ip’ was declared here
  740 |         struct xfs_inode                *ip;
      |                                          ^~

I think this is bogus since xfs_attri_recover_work either returns a real
pointer having initialized ip or an ERR_PTR having not touched it, but
the tools are smarter than me so let's just null-init the variable
anyway.

Cc: stable@vger.kernel.org # v6.8
Fixes: e70fb328 ("xfs: recreate work items when recovering intent items")
Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent 5990fd75

fs/xfs/xfs_attr_item.c

+1 −1
Original line number Diff line number Diff line
@@ -737,7 +737,7 @@ xfs_attr_recover_work( 
	struct xfs_attri_log_item	*attrip = ATTRI_ITEM(lip);

	struct xfs_attr_intent		*attr;

	struct xfs_mount		*mp = lip->li_log->l_mp;

	struct xfs_inode		*ip;

	struct xfs_inode		*ip = NULL;

	struct xfs_da_args		*args;

	struct xfs_trans		*tp;

	struct xfs_trans_res		resv;