Commit f079ff37 authored by Changqing Li's avatar Changqing Li Committed by Arnaldo Carvalho de Melo
Browse files

tools build: Make in-target rule robust against too long argument error 



The command length of in-target scales with the depth of the directory
times the number of objects in the Makefile.

When there are many objects, and O=[absolute_path] is set, and the
absolute_path is relatively long.

It is possible that this line "$(call if_changed,$(host)ld_multi)" will
report error: "make[4]: /bin/sh: Argument list too long"

For example, build perf tools with O=/long/output/path

Like built-in.a and *.mod rules in scripts/Makefile.build, add
$(objpredix)/ by the shell command instead of by Make's builtin
function.

Reviewed-by: default avatarIan Rogers <irogers@google.com>
Signed-off-by: default avatarChangqing Li <changqing.li@windriver.com>
Cc: Charlie Jenkins <charlie@rivosinc.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent cfdf6456

tools/build/Makefile.build

+4 −2
Original line number Diff line number Diff line
@@ -70,11 +70,13 @@ quiet_cmd_gen = GEN $@ 
# If there's nothing to link, create empty $@ object.

quiet_cmd_ld_multi = LD      $@

      cmd_ld_multi = $(if $(strip $(obj-y)),\

                     $(LD) -r -o $@  $(filter $(obj-y),$^),rm -f $@; $(AR) rcs $@)

                     printf "$(objprefix)%s " $(patsubst $(objprefix)%,%,$(filter $(obj-y),$^)) | \

                     xargs $(LD) -r -o $@,rm -f $@; $(AR) rcs $@)



quiet_cmd_host_ld_multi = HOSTLD  $@

      cmd_host_ld_multi = $(if $(strip $(obj-y)),\

                          $(HOSTLD) -r -o $@  $(filter $(obj-y),$^),rm -f $@; $(HOSTAR) rcs $@)

                          printf "$(objprefix)%s " $(patsubst $(objprefix)%,%,$(filter $(obj-y),$^)) | \

                          xargs $(HOSTLD) -r -o $@,rm -f $@; $(HOSTAR) rcs $@)



rust_common_cmd = \

	$(RUSTC) $(rust_flags) \