Commit f07ebfa5 authored Oct 27, 2025 by Thorsten Blum Committed by Heiko Carstens Nov 06, 2025

s390/nmi: Annotate s390_handle_damage() with __noreturn



s390_handle_damage() ends by calling the non-returning function
disabled_wait() and therefore also never returns. Annotate it with the
__noreturn compiler attribute to improve compiler optimizations.

Remove the unreachable infinite while loop.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

parent 858063c1

arch/s390/kernel/nmi.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -184,7 +184,7 @@ static notrace void nmi_print_info(void)
		sclp_emergency_printk(message);
		}

		static notrace void s390_handle_damage(void)
		static notrace void __noreturn s390_handle_damage(void)
		{
		struct lowcore *lc = get_lowcore();
		union ctlreg0 cr0, cr0_new;
		@@ -214,7 +214,6 @@ static notrace void s390_handle_damage(void)
		lc->mcck_new_psw = psw_save;
		local_ctl_load(0, &cr0.reg);
		disabled_wait();
		while (1);
		}
		NOKPROBE_SYMBOL(s390_handle_damage);