Commit f0969627 authored by R Nageswara Sastry's avatar R Nageswara Sastry Committed by Michael Ellerman
Browse files

selftests/powerpc/papr_vpd: Check devfd before get_system_loc_code() 



Calling get_system_loc_code before checking devfd and errno fails the test
when the device is not available, the expected behaviour is a SKIP.

Change the order of 'SKIP_IF_MSG' to correctly SKIP when the /dev/
papr-vpd device is not available.

Test output before:
  Test FAILED on line 271

Test output after:
  [SKIP] Test skipped on line 266: /dev/papr-vpd not present

Signed-off-by: default avatarR Nageswara Sastry <rnsastry@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240131130859.14968-1-rnsastry@linux.ibm.com
parent aad98efd

tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c

+2 −2
Original line number Diff line number Diff line
@@ -263,10 +263,10 @@ static int papr_vpd_system_loc_code(void) 
	off_t size;

	int fd;



	SKIP_IF_MSG(get_system_loc_code(&lc),

		    "Cannot determine system location code");

	SKIP_IF_MSG(devfd < 0 && errno == ENOENT,

		    DEVPATH " not present");

	SKIP_IF_MSG(get_system_loc_code(&lc),

		    "Cannot determine system location code");



	FAIL_IF(devfd < 0);