Commit f0cafb02 authored by Chenghai Huang's avatar Chenghai Huang Committed by Herbert Xu
Browse files

crypto: hisilicon/qm - set NULL to qm->debug.qm_diff_regs 



When the initialization of qm->debug.acc_diff_reg fails,
the probe process does not exit. However, after qm->debug.qm_diff_regs is
freed, it is not set to NULL. This can lead to a double free when the
remove process attempts to free it again. Therefore, qm->debug.qm_diff_regs
should be set to NULL after it is freed.

Fixes: 8be09133 ("crypto: hisilicon/debugfs - Fix debugfs uninit process issue")
Signed-off-by: default avatarChenghai Huang <huangchenghai2@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 64b9642f

drivers/crypto/hisilicon/debugfs.c

+1 −0
Original line number Diff line number Diff line
@@ -888,6 +888,7 @@ static int qm_diff_regs_init(struct hisi_qm *qm, 
		dfx_regs_uninit(qm, qm->debug.qm_diff_regs, ARRAY_SIZE(qm_diff_regs));

		ret = PTR_ERR(qm->debug.acc_diff_regs);

		qm->debug.acc_diff_regs = NULL;

		qm->debug.qm_diff_regs = NULL;

		return ret;

	}