Unverified Commit f0dfdcbe authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

ASoC: codecs: wcd938x-sdw: fix use after free on driver unbind 



Make sure to deregister the component when the driver is being unbound
and before the underlying device-managed resources are freed.

Fixes: 16572522 ("ASoC: codecs: wcd938x-sdw: add SoundWire driver")
Cc: stable@vger.kernel.org      # 5.14
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20231003155558.27079-7-johan+linaro@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3ebebb2c

sound/soc/codecs/wcd938x-sdw.c

+10 −0
Original line number Diff line number Diff line
@@ -1281,6 +1281,15 @@ static int wcd9380_probe(struct sdw_slave *pdev, 
	return component_add(dev, &wcd938x_sdw_component_ops);

}



static int wcd9380_remove(struct sdw_slave *pdev)

{

	struct device *dev = &pdev->dev;



	component_del(dev, &wcd938x_sdw_component_ops);



	return 0;

}



static const struct sdw_device_id wcd9380_slave_id[] = {

	SDW_SLAVE_ENTRY(0x0217, 0x10d, 0),

	{},
@@ -1320,6 +1329,7 @@ static const struct dev_pm_ops wcd938x_sdw_pm_ops = { 


static struct sdw_driver wcd9380_codec_driver = {

	.probe	= wcd9380_probe,

	.remove	= wcd9380_remove,

	.ops = &wcd9380_slave_ops,

	.id_table = wcd9380_slave_id,

	.driver = {