Commit f0e0c809 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde
Browse files

can: dev: can_restart(): move debug message and stats after successful restart 

Move the debug message "restarted" and the CAN restart stats_after_
the successful restart of the CAN device, because the restart may
fail.

While there update the error message from printing the error number to
printing symbolic error names.

Link: https://lore.kernel.org/all/20231005-can-dev-fix-can-restart-v2-4-91b5c1fd922c@pengutronix.de


Reviewed-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
[mkl: mention stats in subject and description, too]
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 8f3ec204

drivers/net/can/dev/dev.c

+4 −4
Original line number Diff line number Diff line
@@ -147,15 +147,15 @@ static void can_restart(struct net_device *dev) 
		netif_rx(skb);

	}



	netdev_dbg(dev, "restarted\n");

	priv->can_stats.restarts++;



	/* Now restart the device */

	netif_carrier_on(dev);

	err = priv->do_set_mode(dev, CAN_MODE_START);

	if (err) {

		netdev_err(dev, "Error %d during restart", err);

		netdev_err(dev, "Restart failed, error %pe\n", ERR_PTR(err));

		netif_carrier_off(dev);

	} else {

		netdev_dbg(dev, "Restarted\n");

		priv->can_stats.restarts++;

	}

}