Commit f0ea2e91 authored by Alok Tiwari's avatar Alok Tiwari Committed by Michael S. Tsirkin
Browse files

vdpa/mlx5: Fix incorrect error code reporting in query_virtqueues 



When query_virtqueues() fails, the error log prints the variable err
instead of cmd->err. Since err may still be zero at this point, the
log message can misleadingly report a success value 0 even though the
command actually failed.

Even worse, once err is set to the first failure, subsequent logs
print that same stale value. This makes the error reporting appear
one step behind the actual failing queue index, which is confusing
and misleading.

Fix the log to report cmd->err, which reflects the real failure code
returned by the firmware.

Fixes: 1fcdf43e ("vdpa/mlx5: Use async API for vq query command")
Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Reviewed-by: default avatarDragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Message-Id: <20250929134258.80956-1-alok.a.tiwari@oracle.com>
parent deb55fc9

drivers/vdpa/mlx5/net/mlx5_vnet.c

+1 −1
Original line number Diff line number Diff line
@@ -1256,7 +1256,7 @@ static int query_virtqueues(struct mlx5_vdpa_net *ndev, 
		int vq_idx = start_vq + i;



		if (cmd->err) {

			mlx5_vdpa_err(mvdev, "query vq %d failed, err: %d\n", vq_idx, err);

			mlx5_vdpa_err(mvdev, "query vq %d failed, err: %d\n", vq_idx, cmd->err);

			if (!err)

				err = cmd->err;

			continue;