Commit f0ebe9e5 authored by Pratap Nirujogi's avatar Pratap Nirujogi Committed by Alex Deucher
Browse files

drm/amd/amdgpu: Refine isp_v4_1_1 logging 



Replace DRM_ERROR with drm_err function and update log
messages to drop __func__ and print return value.

Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarPratap Nirujogi <pratap.nirujogi@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent fd147860

drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c

+6 −12
Original line number Diff line number Diff line
@@ -220,8 +220,7 @@ static int isp_v4_1_1_hw_init(struct amdgpu_isp *isp) 
	isp->isp_cell = kcalloc(3, sizeof(struct mfd_cell), GFP_KERNEL);

	if (!isp->isp_cell) {

		r = -ENOMEM;

		drm_err(&adev->ddev,

			"%s: isp mfd cell alloc failed\n", __func__);

		drm_err(&adev->ddev, "isp mfd cell alloc failed (%d)\n", r);

		goto failure;

	}
@@ -231,16 +230,14 @@ static int isp_v4_1_1_hw_init(struct amdgpu_isp *isp) 
			       GFP_KERNEL);

	if (!isp->isp_res) {

		r = -ENOMEM;

		drm_err(&adev->ddev,

			"%s: isp mfd res alloc failed\n", __func__);

		drm_err(&adev->ddev, "isp mfd resource alloc failed (%d)\n", r);

		goto failure;

	}



	isp->isp_pdata = kzalloc(sizeof(*isp->isp_pdata), GFP_KERNEL);

	if (!isp->isp_pdata) {

		r = -ENOMEM;

		drm_err(&adev->ddev,

			"%s: isp platform data alloc failed\n", __func__);

		drm_err(&adev->ddev, "isp platform data alloc failed (%d)\n", r);

		goto failure;

	}
@@ -278,8 +275,7 @@ static int isp_v4_1_1_hw_init(struct amdgpu_isp *isp) 
	isp->isp_i2c_res = kcalloc(1, sizeof(struct resource), GFP_KERNEL);

	if (!isp->isp_i2c_res) {

		r = -ENOMEM;

		drm_err(&adev->ddev,

			"%s: isp mfd res alloc failed\n", __func__);

		drm_err(&adev->ddev, "isp mfd res alloc failed (%d)\n", r);

		goto failure;

	}
@@ -298,8 +294,7 @@ static int isp_v4_1_1_hw_init(struct amdgpu_isp *isp) 
	isp->isp_gpio_res = kcalloc(1, sizeof(struct resource), GFP_KERNEL);

	if (!isp->isp_gpio_res) {

		r = -ENOMEM;

		drm_err(&adev->ddev,

			"%s: isp gpio res alloc failed\n", __func__);

		drm_err(&adev->ddev, "isp gpio resource alloc failed (%d)\n", r);

		goto failure;

	}
@@ -318,8 +313,7 @@ static int isp_v4_1_1_hw_init(struct amdgpu_isp *isp) 
	/* add only amd_isp_capture and amd_isp_i2c_designware to genpd */

	r = mfd_add_hotplug_devices(isp->parent, isp->isp_cell, 2);

	if (r) {

		drm_err(&adev->ddev,

			"%s: add mfd hotplug device failed\n", __func__);

		drm_err(&adev->ddev, "add mfd hotplug device failed (%d)\n", r);

		goto failure;

	}