Commit f0f367a4 authored by Fedor Pchelkin's avatar Fedor Pchelkin Committed by Jakub Kicinski
Browse files

net: macb: properly unregister fixed rate clocks 



The additional resources allocated with clk_register_fixed_rate() need
to be released with clk_unregister_fixed_rate(), otherwise they are lost.

Fixes: 83a77e9e ("net: macb: Added PCI wrapper for Platform Driver.")
Signed-off-by: default avatarFedor Pchelkin <pchelkin@ispras.ru>
Link: https://patch.msgid.link/20260330184542.626619-2-pchelkin@ispras.ru


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ce8fe528

drivers/net/ethernet/cadence/macb_pci.c

+4 −4
Original line number Diff line number Diff line
@@ -96,10 +96,10 @@ static int macb_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	return 0;



err_plat_dev_register:

	clk_unregister(plat_data.hclk);

	clk_unregister_fixed_rate(plat_data.hclk);



err_hclk_register:

	clk_unregister(plat_data.pclk);

	clk_unregister_fixed_rate(plat_data.pclk);



err_pclk_register:

	return err;
@@ -113,8 +113,8 @@ static void macb_remove(struct pci_dev *pdev) 
	struct clk *hclk = plat_data->hclk;



	platform_device_unregister(plat_dev);

	clk_unregister(pclk);

	clk_unregister(hclk);

	clk_unregister_fixed_rate(pclk);

	clk_unregister_fixed_rate(hclk);

}



static const struct pci_device_id dev_id_table[] = {