Commit f103fa12 authored by Pengjie Zhang's avatar Pengjie Zhang Committed by Rafael J. Wysocki
Browse files

ACPI: PCC: Fix race condition by removing static qualifier 



Local variable 'ret' in acpi_pcc_address_space_setup() is currently
declared as 'static'. This can lead to race conditions in a
multithreaded environment.

Remove the 'static' qualifier to ensure that 'ret' will be allocated
directly on the stack as a local variable.

Fixes: a10b1c99 ("ACPI: PCC: Setup PCC Opregion handler only if platform interrupt is available")
Signed-off-by: default avatarPengjie Zhang <zhangpengjie2@huawei.com>
Reviewed-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Acked-by: default avatar <lihuisong@huawei.com>
Cc: 6.2+ <stable@vger.kernel.org> # 6.2+
[ rjw: Changelog edits ]
Link: https://patch.msgid.link/20251210132634.2050033-1-zhangpengjie2@huawei.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 6ea3a44c

drivers/acpi/acpi_pcc.c

+1 −1
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ acpi_pcc_address_space_setup(acpi_handle region_handle, u32 function, 
	struct pcc_data *data;

	struct acpi_pcc_info *ctx = handler_context;

	struct pcc_mbox_chan *pcc_chan;

	static acpi_status ret;

	acpi_status ret;



	data = kzalloc(sizeof(*data), GFP_KERNEL);

	if (!data)