Commit f1112131 authored by Cristian Ciocaltea's avatar Cristian Ciocaltea Committed by Lee Jones
Browse files

dt-bindings: mfd: rk817: Merge support for RK809 

The Rockchip RK809 PMIC is compatible with RK817 and provides the same
capabilities, except for the battery charger manager.

There are also minor regulator related differences: BOOST and OTG_SWITCH
are specific to RK817, while DCDC_REG5, SWITCH_REG1 and SWITCH_REG2 are
provided RK809.

The current binding for RK809 doesn't document the audio codec
properties, although it has been already in use by several boards:
rk3566-quartz64-b, k3566-roc-pc, rk3568-evb1-v10, rk3568-lubancat-2,
rk3568-odroid-m1, rk3568-rock-3a.

Therefore dtbs_check fails for all of them:

  DTC_CHK arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb
  rk3568-rock-3a.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks', 'codec' do not match any of the regexes: 'pinctrl-[0-9]+'
    from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#



Additionally, the example in rockchip,rk809 binding is not able to
actually test the schema since it uses a wrong compatible
'rockchip,rk808' instead of the expected 'rockchip,rk809'.

Instead of duplicating even more content, merge the RK809 support into
the more inclusive RK817 schema and drop the now obsolete rockchip,rk809
related file.

Fixes: 6c38ca03 ("dt-bindings: mfd: rk808: Convert bindings to yaml")
Signed-off-by: default avatarCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20240622-rk809-fixes-v2-2-c0db420d3639@collabora.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent e7865de2

Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml

deleted100644 → 0
+0 −288
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause

%YAML 1.2

---

$id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: RK809 Power Management Integrated Circuit



maintainers:

  - Chris Zhong <zyw@rock-chips.com>

  - Zhang Qing <zhangqing@rock-chips.com>



description: |

  Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD

  that includes regulators, an RTC, and power button.



properties:

  compatible:

    enum:

      - rockchip,rk809



  reg:

    maxItems: 1



  interrupts:

    maxItems: 1



  '#clock-cells':

    description: |

      See <dt-bindings/clock/rockchip,rk808.h> for clock IDs.

    minimum: 0

    maximum: 1



  clock-output-names:

    description:

      From common clock binding to override the default output clock name.



  rockchip,system-power-controller:

    type: boolean

    deprecated: true

    description:

      Telling whether or not this PMIC is controlling the system power.



  system-power-controller: true



  wakeup-source:

    type: boolean

    description:

      Device can be used as a wakeup source.



  vcc1-supply:

    description:

      The input supply for DCDC_REG1.



  vcc2-supply:

    description:

      The input supply for DCDC_REG2.



  vcc3-supply:

    description:

      The input supply for DCDC_REG3.



  vcc4-supply:

    description:

      The input supply for DCDC_REG4.



  vcc5-supply:

    description:

      The input supply for LDO_REG1, LDO_REG2, and LDO_REG3.



  vcc6-supply:

    description:

      The input supply for LDO_REG4, LDO_REG5, and LDO_REG6.



  vcc7-supply:

    description:

      The input supply for LDO_REG7, LDO_REG8, and LDO_REG9.



  vcc8-supply:

    description:

      The input supply for SWITCH_REG1.



  vcc9-supply:

    description:

      The input supply for DCDC_REG5 and SWITCH_REG2.



  regulators:

    type: object

    patternProperties:

      "^(LDO_REG[1-9]|DCDC_REG[1-5]|SWITCH_REG[1-2])$":

        type: object

        $ref: /schemas/regulator/regulator.yaml#

        unevaluatedProperties: false

    unevaluatedProperties: false



allOf:

  - if:

      properties:

        '#clock-cells':

          const: 0



    then:

      properties:

        clock-output-names:

          maxItems: 1



    else:

      properties:

        clock-output-names:

          maxItems: 2



required:

  - compatible

  - reg

  - interrupts

  - "#clock-cells"



additionalProperties: false



examples:

  - |

    #include <dt-bindings/pinctrl/rockchip.h>

    #include <dt-bindings/interrupt-controller/irq.h>

    #include <dt-bindings/gpio/gpio.h>

    i2c {

        #address-cells = <1>;

        #size-cells = <0>;



        rk808: pmic@1b {

            compatible = "rockchip,rk808";

            reg = <0x1b>;

            #clock-cells = <1>;

            clock-output-names = "xin32k", "rk808-clkout2";

            interrupt-parent = <&gpio3>;

            interrupts = <10 IRQ_TYPE_LEVEL_LOW>;

            pinctrl-names = "default";

            pinctrl-0 = <&pmic_int_l_pin>;

            rockchip,system-power-controller;

            wakeup-source;



            vcc1-supply = <&vcc_sysin>;

            vcc2-supply = <&vcc_sysin>;

            vcc3-supply = <&vcc_sysin>;

            vcc4-supply = <&vcc_sysin>;

            vcc6-supply = <&vcc_sysin>;

            vcc7-supply = <&vcc_sysin>;

            vcc8-supply = <&vcc3v3_sys>;

            vcc9-supply = <&vcc_sysin>;

            vcc10-supply = <&vcc_sysin>;

            vcc11-supply = <&vcc_sysin>;

            vcc12-supply = <&vcc3v3_sys>;



            regulators {

                vdd_center: DCDC_REG1 {

                    regulator-name = "vdd_center";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-min-microvolt = <750000>;

                    regulator-max-microvolt = <1350000>;

                    regulator-ramp-delay = <6001>;

                    regulator-state-mem {

                        regulator-off-in-suspend;

                    };

                };



                vdd_cpu_l: DCDC_REG2 {

                    regulator-name = "vdd_cpu_l";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-min-microvolt = <750000>;

                    regulator-max-microvolt = <1350000>;

                    regulator-ramp-delay = <6001>;

                    regulator-state-mem {

                        regulator-off-in-suspend;

                    };

                };



                vcc_ddr: DCDC_REG3 {

                    regulator-name = "vcc_ddr";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-state-mem {

                        regulator-on-in-suspend;

                    };

                };



                vcc_1v8: vcc_wl: DCDC_REG4 {

                    regulator-name = "vcc_1v8";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-min-microvolt = <1800000>;

                    regulator-max-microvolt = <1800000>;

                    regulator-state-mem {

                        regulator-on-in-suspend;

                        regulator-suspend-microvolt = <1800000>;

                    };

                };



                vcc1v8_pmupll: LDO_REG3 {

                    regulator-name = "vcc1v8_pmupll";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-min-microvolt = <1800000>;

                    regulator-max-microvolt = <1800000>;

                    regulator-state-mem {

                        regulator-on-in-suspend;

                        regulator-suspend-microvolt = <1800000>;

                    };

                };



                vcc_sdio: LDO_REG4 {

                    regulator-name = "vcc_sdio";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-min-microvolt = <1800000>;

                    regulator-max-microvolt = <3000000>;

                    regulator-state-mem {

                        regulator-on-in-suspend;

                        regulator-suspend-microvolt = <3000000>;

                    };

                };



                vcca3v0_codec: LDO_REG5 {

                    regulator-name = "vcca3v0_codec";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-min-microvolt = <3000000>;

                    regulator-max-microvolt = <3000000>;

                    regulator-state-mem {

                        regulator-off-in-suspend;

                    };

                };



                vcc_1v5: LDO_REG6 {

                    regulator-name = "vcc_1v5";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-min-microvolt = <1500000>;

                    regulator-max-microvolt = <1500000>;

                    regulator-state-mem {

                        regulator-on-in-suspend;

                        regulator-suspend-microvolt = <1500000>;

                    };

                };



                vcca1v8_codec: LDO_REG7 {

                    regulator-name = "vcca1v8_codec";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-min-microvolt = <1800000>;

                    regulator-max-microvolt = <1800000>;

                    regulator-state-mem {

                        regulator-off-in-suspend;

                    };

                };



                vcc_3v0: LDO_REG8 {

                    regulator-name = "vcc_3v0";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-min-microvolt = <3000000>;

                    regulator-max-microvolt = <3000000>;

                    regulator-state-mem {

                        regulator-on-in-suspend;

                        regulator-suspend-microvolt = <3000000>;

                    };

                };



                vcc3v3_s3: SWITCH_REG1 {

                    regulator-name = "vcc3v3_s3";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-state-mem {

                        regulator-off-in-suspend;

                    };

                };



                vcc3v3_s0: SWITCH_REG2 {

                    regulator-name = "vcc3v3_s0";

                    regulator-always-on;

                    regulator-boot-on;

                    regulator-state-mem {

                        regulator-off-in-suspend;

                    };

                };

            };

        };

    };

Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml

+27 −10
Original line number Diff line number Diff line
@@ -4,20 +4,21 @@ 
$id: http://devicetree.org/schemas/mfd/rockchip,rk817.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: RK817 Power Management Integrated Circuit

title: RK809/RK817 Power Management Integrated Circuit



maintainers:

  - Chris Zhong <zyw@rock-chips.com>

  - Zhang Qing <zhangqing@rock-chips.com>



description: |

  Rockchip RK817 series PMIC. This device consists of an i2c controlled MFD

  that includes regulators, an RTC, a power button, an audio codec, and a

  battery charger manager.

  Rockchip RK809/RK817 series PMIC. This device consists of an i2c controlled

  MFD that includes regulators, an RTC, a power button and an audio codec.

  The RK817 variant also provides a battery charger manager.



properties:

  compatible:

    enum:

      - rockchip,rk809

      - rockchip,rk817



  reg:
@@ -89,20 +90,20 @@ properties: 


  vcc8-supply:

    description:

      The input supply for BOOST.

      The input supply for BOOST on RK817, or for SWITCH_REG2 on RK809.



  vcc9-supply:

    description:

      The input supply for OTG_SWITCH.

      The input supply for OTG_SWITCH on RK817,

      or for DCDC_REG5 and SWITCH_REG1 on RK809.



  regulators:

    type: object

    patternProperties:

      "^(LDO_REG[1-9]|DCDC_REG[1-4]|BOOST|OTG_SWITCH)$":

        type: object

        unevaluatedProperties: false

        $ref: /schemas/regulator/regulator.yaml#

      "^(LDO_REG[1-9]|DCDC_REG[1-5]|BOOST|OTG_SWITCH|SWITCH_REG[1-2])$":

        $ref: /schemas/regulator/regulator.yaml

        unevaluatedProperties: false

    additionalProperties: false



  codec:

    type: object
@@ -172,6 +173,22 @@ allOf: 
        clock-output-names:

          maxItems: 2



  - if:

      properties:

        compatible:

          contains:

            const: rockchip,rk817

    then:

      properties:

        regulators:

          patternProperties:

            "^(DCDC_REG5|SWITCH_REG[1-2])$": false

    else:

      properties:

        regulators:

          patternProperties:

            "^(BOOST|OTG_SWITCH)$": false



required:

  - compatible

  - reg