Unverified Commit f1296603 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_writebacks() 



drm_atomic_helper_commit_writebacks() updates all writeback connectors
affected by a new commit. It takes the drm_atomic_state being committed
as a parameter.

However, that parameter name is called (and documented) as old_state,
which is pretty confusing. Let's rename that variable as state.

Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-20-e71598f49c8f@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 742043c8

drivers/gpu/drm/drm_atomic_helper.c

+3 −3
Original line number Diff line number Diff line
@@ -1463,13 +1463,13 @@ void drm_atomic_helper_commit_modeset_disables(struct drm_device *dev, 
EXPORT_SYMBOL(drm_atomic_helper_commit_modeset_disables);



static void drm_atomic_helper_commit_writebacks(struct drm_device *dev,

						struct drm_atomic_state *old_state)

						struct drm_atomic_state *state)

{

	struct drm_connector *connector;

	struct drm_connector_state *new_conn_state;

	int i;



	for_each_new_connector_in_state(old_state, connector, new_conn_state, i) {

	for_each_new_connector_in_state(state, connector, new_conn_state, i) {

		const struct drm_connector_helper_funcs *funcs;



		funcs = connector->helper_private;
@@ -1478,7 +1478,7 @@ static void drm_atomic_helper_commit_writebacks(struct drm_device *dev, 


		if (new_conn_state->writeback_job && new_conn_state->writeback_job->fb) {

			WARN_ON(connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK);

			funcs->atomic_commit(connector, old_state);

			funcs->atomic_commit(connector, state);

		}

	}

}