Commit f12af4c4 authored by Tvrtko Ursulin's avatar Tvrtko Ursulin Committed by Luben Tuikov
Browse files

drm/sched: Drop suffix from drm_sched_wakeup_if_can_queue 



Because a) helper is exported to other parts of the scheduler and
b) there isn't a plain drm_sched_wakeup to begin with, I think we can
drop the suffix and by doing so separate the intimiate knowledge
between the scheduler components a bit better.

Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Luben Tuikov <ltuikov89@gmail.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231102105538.391648-6-tvrtko.ursulin@linux.intel.com


Reviewed-by: default avatarLuben Tuikov <ltuikov89@gmail.com>
Signed-off-by: default avatarLuben Tuikov <ltuikov89@gmail.com>
parent 35a4279d

drivers/gpu/drm/scheduler/sched_entity.c

+2 −2
Original line number Diff line number Diff line
@@ -370,7 +370,7 @@ static void drm_sched_entity_wakeup(struct dma_fence *f, 
		container_of(cb, struct drm_sched_entity, cb);



	drm_sched_entity_clear_dep(f, cb);

	drm_sched_wakeup_if_can_queue(entity->rq->sched);

	drm_sched_wakeup(entity->rq->sched);

}



/**
@@ -602,7 +602,7 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job) 
		if (drm_sched_policy == DRM_SCHED_POLICY_FIFO)

			drm_sched_rq_update_fifo(entity, submit_ts);



		drm_sched_wakeup_if_can_queue(entity->rq->sched);

		drm_sched_wakeup(entity->rq->sched);

	}

}

EXPORT_SYMBOL(drm_sched_entity_push_job);

drivers/gpu/drm/scheduler/sched_main.c

+2 −2
Original line number Diff line number Diff line
@@ -920,12 +920,12 @@ static bool drm_sched_can_queue(struct drm_gpu_scheduler *sched) 
}



/**

 * drm_sched_wakeup_if_can_queue - Wake up the scheduler

 * drm_sched_wakeup - Wake up the scheduler if it is ready to queue

 * @sched: scheduler instance

 *

 * Wake up the scheduler if we can queue jobs.

 */

void drm_sched_wakeup_if_can_queue(struct drm_gpu_scheduler *sched)

void drm_sched_wakeup(struct drm_gpu_scheduler *sched)

{

	if (drm_sched_can_queue(sched))

		__drm_sched_run_job_queue(sched);

include/drm/gpu_scheduler.h

+1 −1
Original line number Diff line number Diff line
@@ -559,7 +559,7 @@ void drm_sched_entity_modify_sched(struct drm_sched_entity *entity, 


void drm_sched_tdr_queue_imm(struct drm_gpu_scheduler *sched);

void drm_sched_job_cleanup(struct drm_sched_job *job);

void drm_sched_wakeup_if_can_queue(struct drm_gpu_scheduler *sched);

void drm_sched_wakeup(struct drm_gpu_scheduler *sched);

bool drm_sched_wqueue_ready(struct drm_gpu_scheduler *sched);

void drm_sched_wqueue_stop(struct drm_gpu_scheduler *sched);

void drm_sched_wqueue_start(struct drm_gpu_scheduler *sched);