Unverified Commit f156743c authored by andy.shevchenko@gmail.com's avatar andy.shevchenko@gmail.com Committed by Mark Brown
Browse files

spi: fsl-dspi: Preserve error code returned by dmaengine_slave_config() 



dmaengine_slave_config() may return different error codes based on
the circumstances. Preserve it instead of shadowing to -EINVAL.

Suggested-by: default avatarVladimir Oltean <olteanv@gmail.com>
Signed-off-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20240204203127.1186621-2-andy.shevchenko@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1e942b5b

drivers/spi/spi-fsl-dspi.c

+0 −2
Original line number Diff line number Diff line
@@ -542,7 +542,6 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) 
	ret = dmaengine_slave_config(dma->chan_rx, &cfg);

	if (ret) {

		dev_err(dev, "can't configure rx dma channel\n");

		ret = -EINVAL;

		goto err_slave_config;

	}
@@ -550,7 +549,6 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) 
	ret = dmaengine_slave_config(dma->chan_tx, &cfg);

	if (ret) {

		dev_err(dev, "can't configure tx dma channel\n");

		ret = -EINVAL;

		goto err_slave_config;

	}