Commit f17cd486 authored by Gaston Gonzalez's avatar Gaston Gonzalez Committed by Greg Kroah-Hartman
Browse files

staging: gpib: fix kernel-doc section for usb_gpib_line_status() function 



The function name field in the kernel-doc section for the
usb_gpib_line_status() is defined as 'line_status'. In addition, after
the kernel-doc section, there are three macro definition instead of the
function definition.

These issues trigger the warning:

warning: expecting prototype for line_status(). Prototype was for WQT()
instead.

Fix the warning by renaming the function in the kernel-doc section and
by moving the macros to the beginning of the file with the rest of
macros definition.

Signed-off-by: default avatarGaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20250305193614.39604-7-gascoar@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4ec9b9b5

drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c

+5 −6
Original line number Diff line number Diff line
@@ -78,6 +78,10 @@ module_param(debug, int, 0644); 
			dev_dbg(board->gpib_dev, format, ## __VA_ARGS__); } \

	while (0)



#define WQT wait_queue_entry_t

#define WQH head

#define WQE entry



/* standard and extended command sets of the usb-gpib adapter */



#define USB_GPIB_ON	 "\nIB\n"
@@ -644,17 +648,12 @@ static void usb_gpib_interface_clear(struct gpib_board *board, int assert) 
}



/**

 * line_status() - Read the status of the bus lines.

 * usb_gpib_line_status() - Read the status of the bus lines.

 *

 *  @board:    the gpib_board data area for this gpib interface

 *

 *    We can read all lines.

 */



#define WQT wait_queue_entry_t

#define WQH head

#define WQE entry



static int usb_gpib_line_status(const struct gpib_board *board)

{

	int buffer;