Commit f18029bd authored by Maxime Ripard's avatar Maxime Ripard Committed by Dave Stevenson
Browse files

drm/vc4: plane: Add more debugging for LBM allocation 



LBM allocations need a different size depending on the line length,
format, etc.

This can get tricky, and fail. Let's add some more prints to ease the
debugging when it does.

Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240621152055.4180873-12-dave.stevenson@raspberrypi.com


Signed-off-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
parent 6184b944

drivers/gpu/drm/vc4/vc4_plane.c

+4 −0
Original line number Diff line number Diff line
@@ -741,6 +741,7 @@ static int vc4_plane_allocate_lbm(struct drm_plane_state *state) 
{

	struct drm_device *drm = state->plane->dev;

	struct vc4_dev *vc4 = to_vc4_dev(drm);

	struct drm_plane *plane = state->plane;

	struct vc4_plane_state *vc4_state = to_vc4_plane_state(state);

	unsigned long irqflags;

	u32 lbm_size;
@@ -749,6 +750,9 @@ static int vc4_plane_allocate_lbm(struct drm_plane_state *state) 
	if (!lbm_size)

		return 0;



	drm_dbg_driver(drm, "[PLANE:%d:%s] LBM Allocation Size: %u\n",

		       plane->base.id, plane->name, lbm_size);



	if (WARN_ON(!vc4_state->lbm_offset))

		return -EINVAL;