Commit f185de22 authored by Srinivas Neeli's avatar Srinivas Neeli Committed by Wim Van Sebroeck
Browse files

watchdog: of_xilinx_wdt: Remove passing null pointer 



clk is an optional property, if clock not defined,
calling clk_prepare_enable() and devm_add_action_or_reset()
are not useful.
so calling these two apis only when clock is present.

Addresses-Coverity:"FORWARD_NULL"

Signed-off-by: default avatarSrinivas Neeli <srinivas.neeli@xilinx.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20210329161939.37680-5-srinivas.neeli@xilinx.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent a40b2c3d

drivers/watchdog/of_xilinx_wdt.c

+9 −10
Original line number Diff line number Diff line
@@ -211,6 +211,15 @@ static int xwdt_probe(struct platform_device *pdev) 
				 "The watchdog clock freq cannot be obtained\n");

	} else {

		pfreq = clk_get_rate(xdev->clk);

		rc = clk_prepare_enable(xdev->clk);

		if (rc) {

			dev_err(dev, "unable to enable clock\n");

			return rc;

		}

		rc = devm_add_action_or_reset(dev, xwdt_clk_disable_unprepare,

					      xdev->clk);

		if (rc)

			return rc;

	}



	/*
@@ -224,16 +233,6 @@ static int xwdt_probe(struct platform_device *pdev) 
	spin_lock_init(&xdev->spinlock);

	watchdog_set_drvdata(xilinx_wdt_wdd, xdev);



	rc = clk_prepare_enable(xdev->clk);

	if (rc) {

		dev_err(dev, "unable to enable clock\n");

		return rc;

	}

	rc = devm_add_action_or_reset(dev, xwdt_clk_disable_unprepare,

				      xdev->clk);

	if (rc)

		return rc;



	rc = xwdt_selftest(xdev);

	if (rc == XWT_TIMER_FAILED) {

		dev_err(dev, "SelfTest routine error\n");