Commit f186b2da authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpufreq: intel_pstate: Drop redundant locking from intel_pstate_driver_cleanup() 



Remove the spinlock locking from intel_pstate_driver_cleanup() as it is
not necessary because no other code accessing all_cpu_data[] can run in
parallel with that function.

Had the locking been necessary, though, it would have been incorrect
because the lock in question is acquired from a hardirq handler and
it cannot be acquired from thread context without disabling interrupts.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 39cd87c4

drivers/cpufreq/intel_pstate.c

+0 −2
Original line number Diff line number Diff line
@@ -3135,10 +3135,8 @@ static void intel_pstate_driver_cleanup(void) 
			if (intel_pstate_driver == &intel_pstate)

				intel_pstate_clear_update_util_hook(cpu);



			spin_lock(&hwp_notify_lock);

			kfree(all_cpu_data[cpu]);

			WRITE_ONCE(all_cpu_data[cpu], NULL);

			spin_unlock(&hwp_notify_lock);

		}

	}

	cpus_read_unlock();