Commit f1a68ba5 authored by Johan Hovold's avatar Johan Hovold Committed by Matthias Brugger
Browse files

soc: mediatek: mtk-svs: fix device leaks on mt8192 probe failure 



Make sure to drop the references taken by of_find_device_by_node() when
looking up the thermal sensor and opp devices during probe on probe
failure (e.g. probe deferral) and on driver unbind.

Fixes: 0bbb09b2 ("soc: mediatek: SVS: add mt8192 SVS GPU driver")
Cc: Roger Lu <roger.lu@mediatek.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20250909095651.5530-3-johan@kernel.org


Signed-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
parent 6ab4f79e

drivers/soc/mediatek/mtk-svs.c

+8 −0
Original line number Diff line number Diff line
@@ -2176,6 +2176,7 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp) 
{

	struct device *dev;

	u32 idx;

	int ret;



	svsp->rst = devm_reset_control_get_optional(svsp->dev, "svs_rst");

	if (IS_ERR(svsp->rst))
@@ -2186,6 +2187,7 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp) 
	if (IS_ERR(dev))

		return dev_err_probe(svsp->dev, PTR_ERR(dev),

				     "failed to get lvts device\n");

	put_device(dev);



	for (idx = 0; idx < svsp->bank_max; idx++) {

		struct svs_bank *svsb = &svsp->banks[idx];
@@ -2195,6 +2197,7 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp) 
		case SVSB_SWID_CPU_LITTLE:

		case SVSB_SWID_CPU_BIG:

			svsb->opp_dev = get_cpu_device(bdata->cpu_id);

			get_device(svsb->opp_dev);

			break;

		case SVSB_SWID_CCI:

			svsb->opp_dev = svs_add_device_link(svsp, "cci");
@@ -2214,6 +2217,11 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp) 
			return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev),

					     "failed to get OPP device for bank %d\n",

					     idx);



		ret = devm_add_action_or_reset(svsp->dev, svs_put_device,

					       svsb->opp_dev);

		if (ret)

			return ret;

	}



	return 0;