Commit f1bc03e7 authored by Billy Tsai's avatar Billy Tsai Committed by Bartosz Golaszewski
Browse files

gpio: aspeed: Change the macro to support deferred probe 



Use module_platform_driver() to replace module_platform_driver_probe().
The former utilizes platform_driver_register(), which allows the driver to
defer probing when it doesn't acquire the necessary resources due to probe
order. In contrast, the latter uses __platform_driver_probe(), which
includes the comment "Note that this is incompatible with deferred
probing." Since our GPIO driver requires access to the clock resource, the
former is more suitable.

Reviewed-by: default avatarAndrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: default avatarBilly Tsai <billy_tsai@aspeedtech.com>
Link: https://lore.kernel.org/r/20241008081450.1490955-4-billy_tsai@aspeedtech.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent bebb4574

drivers/gpio/gpio-aspeed.c

+3 −2
Original line number Diff line number Diff line
@@ -1169,7 +1169,7 @@ static const struct of_device_id aspeed_gpio_of_table[] = { 
};

MODULE_DEVICE_TABLE(of, aspeed_gpio_of_table);



static int __init aspeed_gpio_probe(struct platform_device *pdev)

static int aspeed_gpio_probe(struct platform_device *pdev)

{

	const struct of_device_id *gpio_id;

	struct gpio_irq_chip *girq;
@@ -1270,13 +1270,14 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev) 
}



static struct platform_driver aspeed_gpio_driver = {

	.probe = aspeed_gpio_probe,

	.driver = {

		.name = KBUILD_MODNAME,

		.of_match_table = aspeed_gpio_of_table,

	},

};



module_platform_driver_probe(aspeed_gpio_driver, aspeed_gpio_probe);

module_platform_driver(aspeed_gpio_driver);



MODULE_DESCRIPTION("Aspeed GPIO Driver");

MODULE_LICENSE("GPL");