Commit f1d6cd07 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpiolib: Make taking gpio_lookup_lock consistent 



There are two ways to take a lock: plain call to the mutex_lock()
or using guard()() / scoped_guard(). The driver inconsistently uses
both. Make taking gpio_lookup_lock consistent.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250416095645.2027695-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent d0055324

drivers/gpio/gpiolib.c

+2 −6
Original line number Diff line number Diff line
@@ -4363,12 +4363,10 @@ void gpiod_add_lookup_tables(struct gpiod_lookup_table **tables, size_t n) 
{

	unsigned int i;



	mutex_lock(&gpio_lookup_lock);

	guard(mutex)(&gpio_lookup_lock);



	for (i = 0; i < n; i++)

		list_add_tail(&tables[i]->list, &gpio_lookup_list);



	mutex_unlock(&gpio_lookup_lock);

}



/**
@@ -4427,11 +4425,9 @@ void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) 
	if (!table)

		return;



	mutex_lock(&gpio_lookup_lock);

	guard(mutex)(&gpio_lookup_lock);



	list_del(&table->list);



	mutex_unlock(&gpio_lookup_lock);

}

EXPORT_SYMBOL_GPL(gpiod_remove_lookup_table);