Unverified Commit f1d742c3 authored by Ritu Chaudhary's avatar Ritu Chaudhary Committed by Mark Brown
Browse files

ASoC: tegra: Use non-atomic timeout for ADX status register 



ADX startup() callback uses atomic poll timeout on ADX status register.

This is unnecessary because:

- The startup() callback itself is non-atomic.
- The subsequent timeout call in the same function already uses a
  non-atomic version.

Using atomic version can hog CPU when it is not really needed,
so replace it with non-atomic version.

Fixes: a99ab6f3 ("ASoC: tegra: Add Tegra210 based ADX driver")
Signed-off-by: default avatarRitu Chaudhary <rituc@nvidia.com>
Signed-off-by: default avatarSheetal <sheetal@nvidia.com>
Link: https://patch.msgid.link/20250311062010.33412-1-sheetal@nvidia.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0ec6bd16

sound/soc/tegra/tegra210_adx.c

+3 −3
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

// SPDX-FileCopyrightText: Copyright (c) 2021-2024 NVIDIA CORPORATION & AFFILIATES.

// SPDX-FileCopyrightText: Copyright (c) 2021-2025 NVIDIA CORPORATION & AFFILIATES.

// All rights reserved.

//

// tegra210_adx.c - Tegra210 ADX driver
@@ -57,7 +57,7 @@ static int tegra210_adx_startup(struct snd_pcm_substream *substream, 
	int err;



	/* Ensure if ADX status is disabled */

	err = regmap_read_poll_timeout_atomic(adx->regmap, TEGRA210_ADX_STATUS,

	err = regmap_read_poll_timeout(adx->regmap, TEGRA210_ADX_STATUS,

				       val, !(val & 0x1), 10, 10000);

	if (err < 0) {

		dev_err(dai->dev, "failed to stop ADX, err = %d\n", err);