Commit f1ee98cf authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915/fbdev: Fix smem_start for LMEMBAR stolen objects 



The "io" address of an object is its dma address minus the
region.start. Subtract the latter to make smem_start correct.
The current code happens to work for genuine LMEM objects
as LMEM region.start==0, but for LMEMBAR stolen objects
region.start!=0.

TODO: perhaps just set smem_start=0 always as our .fb_mmap()
implementation no longer depends on it? Need to double check
it's not needed for anything else...

Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Tested-by: default avatarPaz Zcharya <pazz@chromium.org>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240202224340.30647-14-ville.syrjala@linux.intel.com
parent 30865e4a

drivers/gpu/drm/i915/display/intel_fbdev_fb.c

+2 −1
Original line number Diff line number Diff line
@@ -79,7 +79,8 @@ int intel_fbdev_fb_fill_info(struct drm_i915_private *i915, struct fb_info *info 
		/* Use fbdev's framebuffer from lmem for discrete */

		info->fix.smem_start =

			(unsigned long)(mem->io.start +

					i915_gem_object_get_dma_address(obj, 0));

					i915_gem_object_get_dma_address(obj, 0) -

					mem->region.start);

		info->fix.smem_len = obj->base.size;

	} else {

		struct i915_ggtt *ggtt = to_gt(i915)->ggtt;