Commit f2052a4a authored by Peter Griffin's avatar Peter Griffin Committed by Krzysztof Kozlowski
Browse files

clk: samsung: gs101: fix synchronous external abort in samsung_clk_save() 



EARLY_WAKEUP_SW_TRIG_*_SET and EARLY_WAKEUP_SW_TRIG_*_CLEAR
registers are only writeable. Attempting to read these registers
during samsung_clk_save() causes a synchronous external abort.

Remove these 8 registers from cmu_top_clk_regs[] array so that
system suspend gets further.

Note: the code path can be exercised using the following command:
echo mem > /sys/power/state

Fixes: 2c597bb7 ("clk: samsung: clk-gs101: Add cmu_top, cmu_misc and cmu_apm support")
Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250303-clk-suspend-fix-v1-1-c2edaf66260f@linaro.org


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent 2014c95a

drivers/clk/samsung/clk-gs101.c

+0 −8
Original line number Diff line number Diff line
@@ -382,17 +382,9 @@ static const unsigned long cmu_top_clk_regs[] __initconst = { 
	EARLY_WAKEUP_DPU_DEST,

	EARLY_WAKEUP_CSIS_DEST,

	EARLY_WAKEUP_SW_TRIG_APM,

	EARLY_WAKEUP_SW_TRIG_APM_SET,

	EARLY_WAKEUP_SW_TRIG_APM_CLEAR,

	EARLY_WAKEUP_SW_TRIG_CLUSTER0,

	EARLY_WAKEUP_SW_TRIG_CLUSTER0_SET,

	EARLY_WAKEUP_SW_TRIG_CLUSTER0_CLEAR,

	EARLY_WAKEUP_SW_TRIG_DPU,

	EARLY_WAKEUP_SW_TRIG_DPU_SET,

	EARLY_WAKEUP_SW_TRIG_DPU_CLEAR,

	EARLY_WAKEUP_SW_TRIG_CSIS,

	EARLY_WAKEUP_SW_TRIG_CSIS_SET,

	EARLY_WAKEUP_SW_TRIG_CSIS_CLEAR,

	CLK_CON_MUX_MUX_CLKCMU_BO_BUS,

	CLK_CON_MUX_MUX_CLKCMU_BUS0_BUS,

	CLK_CON_MUX_MUX_CLKCMU_BUS1_BUS,