Commit f20b7671 authored by Himal Prasad Ghimiray's avatar Himal Prasad Ghimiray Committed by Lucas De Marchi
Browse files

drm/xe: Use USEC_PER_MSEC rather than the hard coding 



Use USEC_PER_MSEC rather than the hard coded value of 1000.

Static analyzer Reported "casting either timeout_ms or
1000U to type u64" to avoid overflow-before-widen.
Using USEC_PER_MSEC seems better and will help with static analyzer
report cleanup.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarHimal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240320083325.3258720-1-himal.prasad.ghimiray@intel.com


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent ee3b1e31

drivers/gpu/drm/xe/xe_pcode.c

+1 −1
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ static int pcode_mailbox_rw(struct xe_gt *gt, u32 mbox, u32 *data0, u32 *data1, 
	xe_mmio_write32(gt, PCODE_MAILBOX, PCODE_READY | mbox);



	err = xe_mmio_wait32(gt, PCODE_MAILBOX, PCODE_READY, 0,

			     timeout_ms * 1000, NULL, atomic);

			     timeout_ms * USEC_PER_MSEC, NULL, atomic);

	if (err)

		return err;