Commit f2483b3f authored Mar 30, 2026 by Srinivasan Shanmugam Committed by Alex Deucher Apr 03, 2026

drm/amd/display: Fix parameter mismatch in panel self-refresh helper



Align parameter names with function arguments.

The function controls panel self-refresh enable/disable based on vblank
and VRR state.

Fixes the below with gcc W=1:
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'dm' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'acrtc' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'stream' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'dm' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'acrtc' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'stream' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'

Fixes: 75400348 ("drm/amd/display: Add Idle state manager(ISM)")
Cc: Ray Wu <ray.wu@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Roman Li <roman.li@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Tom Chung <chiahsuan.chung@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent bf3fc94c

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c

+10 −11

Original line number	Diff line number	Diff line
		@@ -101,12 +101,11 @@ bool amdgpu_dm_crtc_vrr_active(const struct dm_crtc_state *dm_state)

		/**
		* amdgpu_dm_crtc_set_panel_sr_feature() - Manage panel self-refresh features.
		*
		* @vblank_work: is a pointer to a struct vblank_control_work object.
		* @vblank_enabled: indicates whether the DRM vblank counter is currently
		* enabled (true) or disabled (false).
		* @allow_sr_entry: represents whether entry into the self-refresh mode is
		* allowed (true) or not allowed (false).
		* @dm: amdgpu display manager instance.
		* @acrtc: CRTC whose panel self-refresh state is being updated.
		* @stream: DC stream associated with @acrtc.
		* @vblank_enabled: Whether the DRM vblank counter is currently enabled.
		* @allow_sr_entry: Whether entry into self-refresh mode is allowed.
		*
		* The DRM vblank counter enable/disable action is used as the trigger to enable
		* or disable various panel self-refresh features:
		@@ -116,7 +115,7 @@ bool amdgpu_dm_crtc_vrr_active(const struct dm_crtc_state *dm_state)
		* - VRR is disabled
		* - vblank counter is disabled
		* - entry is allowed: usermode demonstrates an adequate number of fast
		* commits)
		* commits
		* - CRC capture window isn't active
		* - Keep enabled even when vblank counter gets enabled
		*