Unverified Commit f2602fba authored by Simon Trimmer's avatar Simon Trimmer Committed by Mark Brown
Browse files

ASoC: cs35l56: Avoid static analysis warning of uninitialised variable 



Static checkers complain that the silicon_uid variable passed by
pointer to cs35l56_read_silicon_uid() could later be used
uninitialised when calling cs_amp_get_efi_calibration_data().

cs35l56_read_silicon_uid() must have succeeded to call
cs_amp_get_efi_calibration_data() and that would have populated the
variable.

However, initialise the value so we are not haunted by it forevermore.

Signed-off-by: default avatarSimon Trimmer <simont@opensource.cirrus.com>
Fixes: e1830f66 ("ASoC: cs35l56: Add helper functions for amp calibration")
Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20240422103211.236063-1-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 32ac5019

sound/soc/codecs/cs35l56-shared.c

+1 −1
Original line number Diff line number Diff line
@@ -706,7 +706,7 @@ EXPORT_SYMBOL_NS_GPL(cs35l56_calibration_controls, SND_SOC_CS35L56_SHARED); 


int cs35l56_get_calibration(struct cs35l56_base *cs35l56_base)

{

	u64 silicon_uid;

	u64 silicon_uid = 0;

	int ret;



	/* Driver can't apply calibration to a secured part, so skip */