Commit f2b8ebfb authored by Stefan Wahren's avatar Stefan Wahren Committed by Greg Kroah-Hartman
Browse files

staging: vchiq_arm: Make vchiq_shutdown never fail 



Most of the users of vchiq_shutdown ignore the return value,
which is bad because this could lead to resource leaks.
So instead of changing all calls to vchiq_shutdown, it's easier
to make vchiq_shutdown never fail.

Fixes: 71bad7f0 ("staging: add bcm2708 vchiq driver")
Signed-off-by: default avatarStefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20250715161108.3411-4-wahrenst@gmx.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 228af5a5

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

+1 −2
Original line number Diff line number Diff line
@@ -393,8 +393,7 @@ int vchiq_shutdown(struct vchiq_instance *instance) 
	struct vchiq_state *state = instance->state;

	int ret = 0;



	if (mutex_lock_killable(&state->mutex))

		return -EAGAIN;

	mutex_lock(&state->mutex);



	/* Remove all services */

	vchiq_shutdown_internal(state, instance);