Unverified Commit f2daa466 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown
Browse files

spi: Use sysfs_emit() to instead of s*printf() 



Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230710154932.68377-7-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2b308e71

drivers/spi/spi.c

+3 −4
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) 
	if (len != -ENODEV)

		return len;



	return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias);

	return sysfs_emit(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias);

}

static DEVICE_ATTR_RO(modalias);
@@ -89,7 +89,7 @@ static ssize_t driver_override_show(struct device *dev, 
	ssize_t len;



	device_lock(dev);

	len = snprintf(buf, PAGE_SIZE, "%s\n", spi->driver_override ? : "");

	len = sysfs_emit(buf, "%s\n", spi->driver_override ? : "");

	device_unlock(dev);

	return len;

}
@@ -2814,8 +2814,7 @@ static ssize_t slave_show(struct device *dev, struct device_attribute *attr, 
	struct device *child;



	child = device_find_any_child(&ctlr->dev);

	return sprintf(buf, "%s\n",

		       child ? to_spi_device(child)->modalias : NULL);

	return sysfs_emit(buf, "%s\n", child ? to_spi_device(child)->modalias : NULL);

}



static ssize_t slave_store(struct device *dev, struct device_attribute *attr,