Commit f2e5812f authored Aug 02, 2023 by Ruan Jinjie Committed by Greg Kroah-Hartman Aug 04, 2023

usb: host: Do not check for 0 return after calling platform_get_irq()



It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Justin Chen <justin.chen@broadcom.com>
Link: https://lore.kernel.org/r/20230802031236.2272196-1-ruanjinjie@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 98d6db05

drivers/usb/host/ehci-atmel.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -102,8 +102,8 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev)
		pr_debug("Initializing Atmel-SoC USB Host Controller\n");

		irq = platform_get_irq(pdev, 0);
		if (irq <= 0) {
		retval = -ENODEV;
		if (irq < 0) {
		retval = irq;
		goto fail_create_hcd;
		}

drivers/usb/host/ehci-brcm.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -140,8 +140,8 @@ static int ehci_brcm_probe(struct platform_device *pdev)
		return err;

		irq = platform_get_irq(pdev, 0);
		if (irq <= 0)
		return irq ? irq : -EINVAL;
		if (irq < 0)
		return irq;

		/* Hook the hub control routine to work around a bug */
		ehci_brcm_hc_driver.hub_control = ehci_brcm_hub_control;

drivers/usb/host/ehci-orion.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -218,8 +218,8 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
		pr_debug("Initializing Orion-SoC USB Host Controller\n");

		irq = platform_get_irq(pdev, 0);
		if (irq <= 0) {
		err = -ENODEV;
		if (irq < 0) {
		err = irq;
		goto err;
		}

drivers/usb/host/ehci-sh.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -82,8 +82,8 @@ static int ehci_hcd_sh_probe(struct platform_device *pdev)
		return -ENODEV;

		irq = platform_get_irq(pdev, 0);
		if (irq <= 0) {
		ret = -ENODEV;
		if (irq < 0) {
		ret = irq;
		goto fail_create_hcd;
		}