Commit f311a057 authored by Adrian Ng Ho Yin's avatar Adrian Ng Ho Yin Committed by Alexandre Belloni
Browse files

i3c: dw-i3c-master: Set SIR_REJECT in DAT on device attach and reattach 



The DesignWare I3C master controller ACKs IBIs as soon as a valid
Device Address Table (DAT) entry is present. This can create a race
between device attachment (after DAA) and the point where the client
driver enables IBIs via i3c_device_enable_ibi().

Set DEV_ADDR_TABLE_SIR_REJECT in the DAT entry during
attach_i3c_dev() and reattach_i3c_dev() so that IBIs are rejected
by default. The bit is managed thereafter by the existing
dw_i3c_master_set_sir_enabled() function, which clears it in
enable_ibi() after ENEC is issued, and restores it in disable_ibi()
after DISEC.

Fixes: 1dd728f5 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: default avatarAdrian Ng Ho Yin <adrianhoyin.ng@altera.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/53f5b8cbdd8af789ec38b95b02873f32f9182dd6.1770962368.git.adrianhoyin.ng@altera.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent f26ecaa0

drivers/i3c/master/dw-i3c-master.c

+2 −2
Original line number Diff line number Diff line
@@ -1024,7 +1024,7 @@ static int dw_i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev, 
		master->free_pos &= ~BIT(pos);

	}



	writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr),

	writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr) | DEV_ADDR_TABLE_SIR_REJECT,

	       master->regs +

	       DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index));
@@ -1053,7 +1053,7 @@ static int dw_i3c_master_attach_i3c_dev(struct i3c_dev_desc *dev) 
	master->free_pos &= ~BIT(pos);

	i3c_dev_set_master_data(dev, data);



	writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(master->devs[pos].addr),

	writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(master->devs[pos].addr) | DEV_ADDR_TABLE_SIR_REJECT,

	       master->regs +

	       DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index));