Unverified Commit f31e0d0c authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

ASoC: tlv320adc3xxx: Don't strip remove function when driver is builtin 



Using __exit for the remove function results in the remove callback
being discarded with SND_SOC_TLV320ADC3XXX=y. When such a device gets
unbound (e.g. using sysfs or hotplug), the driver is just removed
without the cleanup being performed. This results in resource leaks. Fix
it by compiling in the remove callback unconditionally.

This also fixes a W=1 modpost warning:

	WARNING: modpost: sound/soc/codecs/snd-soc-tlv320adc3xxx: section mismatch in reference: adc3xxx_i2c_driver+0x10 (section: .data) -> adc3xxx_i2c_remove (section: .exit.text)

(which only happens with SND_SOC_TLV320ADC3XXX=m).

Fixes: e9a3b57e ("ASoC: codec: tlv320adc3xxx: New codec driver")
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Link: https://msgid.link/r/20240310143852.397212-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6c023ad3

sound/soc/codecs/tlv320adc3xxx.c

+2 −2
Original line number Diff line number Diff line
@@ -1429,7 +1429,7 @@ static int adc3xxx_i2c_probe(struct i2c_client *i2c) 
	return ret;

}



static void __exit adc3xxx_i2c_remove(struct i2c_client *client)

static void adc3xxx_i2c_remove(struct i2c_client *client)

{

	struct adc3xxx *adc3xxx = i2c_get_clientdata(client);
@@ -1452,7 +1452,7 @@ static struct i2c_driver adc3xxx_i2c_driver = { 
		   .of_match_table = tlv320adc3xxx_of_match,

		  },

	.probe = adc3xxx_i2c_probe,

	.remove = __exit_p(adc3xxx_i2c_remove),

	.remove = adc3xxx_i2c_remove,

	.id_table = adc3xxx_i2c_id,

};