Commit f31e3c20 authored by Zheng Yongjun's avatar Zheng Yongjun Committed by Shawn Guo
Browse files

ARM: mxs: fix memory leak in mxs_machine_init() 



If of_property_read_string() failed, 'soc_dev_attr' should be
freed before return. Otherwise there is a memory leak.

Fixes: 2046338d ("ARM: mxs: Use soc bus infrastructure")
Signed-off-by: default avatarZheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: default avatarMarco Felsch <m.felsch@pengutronix.de>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 836fb309

arch/arm/mach-mxs/mach-mxs.c

+3 −1
Original line number Diff line number Diff line
@@ -393,8 +393,10 @@ static void __init mxs_machine_init(void) 


	root = of_find_node_by_path("/");

	ret = of_property_read_string(root, "model", &soc_dev_attr->machine);

	if (ret)

	if (ret) {

		kfree(soc_dev_attr);

		return;

	}



	soc_dev_attr->family = "Freescale MXS Family";

	soc_dev_attr->soc_id = mxs_get_soc_id();