Commit f327bfdb authored by Tejas Vipin's avatar Tejas Vipin Committed by Douglas Anderson
Browse files

drm/panel: samsung-s6e3fa7: transition to mipi_dsi wrapped functions 



Changes the samsung-s6e3fa7 panel to use multi style functions for
improved error handling.

Signed-off-by: default avatarTejas Vipin <tejasvipin76@gmail.com>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarJessica Zhang <quic_jesszhan@quicinc.com>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240902071019.351158-1-tejasvipin76@gmail.com
parent 7ab6512e

drivers/gpu/drm/panel/panel-samsung-s6e3fa7.c

+21 −50
Original line number Diff line number Diff line
@@ -38,57 +38,38 @@ static void s6e3fa7_panel_reset(struct s6e3fa7_panel *ctx) 
	usleep_range(10000, 11000);

}



static int s6e3fa7_panel_on(struct s6e3fa7_panel *ctx)

static int s6e3fa7_panel_on(struct mipi_dsi_device *dsi)

{

	struct mipi_dsi_device *dsi = ctx->dsi;

	struct device *dev = &dsi->dev;

	int ret;

	struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };



	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to exit sleep mode: %d\n", ret);

		return ret;

	}

	msleep(120);

	mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);

	mipi_dsi_msleep(&dsi_ctx, 120);

	mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx, MIPI_DSI_DCS_TEAR_MODE_VBLANK);



	ret = mipi_dsi_dcs_set_tear_on(dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);

	if (ret < 0) {

		dev_err(dev, "Failed to set tear on: %d\n", ret);

		return ret;

	}



	mipi_dsi_dcs_write_seq(dsi, 0xf0, 0x5a, 0x5a);

	mipi_dsi_dcs_write_seq(dsi, 0xf4,

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf4,

				     0xbb, 0x23, 0x19, 0x3a, 0x9f, 0x0f, 0x09, 0xc0,

				     0x00, 0xb4, 0x37, 0x70, 0x79, 0x69);

	mipi_dsi_dcs_write_seq(dsi, 0xf0, 0xa5, 0xa5);

	mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x20);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x20);



	ret = mipi_dsi_dcs_set_display_on(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to set display on: %d\n", ret);

		return ret;

	}

	mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);



	return 0;

	return dsi_ctx.accum_err;

}



static int s6e3fa7_panel_prepare(struct drm_panel *panel)

{

	struct s6e3fa7_panel *ctx = to_s6e3fa7_panel(panel);

	struct device *dev = &ctx->dsi->dev;

	int ret;



	s6e3fa7_panel_reset(ctx);



	ret = s6e3fa7_panel_on(ctx);

	if (ret < 0) {

		dev_err(dev, "Failed to initialize panel: %d\n", ret);

	ret = s6e3fa7_panel_on(ctx->dsi);

	if (ret < 0)

		gpiod_set_value_cansleep(ctx->reset_gpio, 1);

		return ret;

	}



	return 0;

	return ret;

}



static int s6e3fa7_panel_unprepare(struct drm_panel *panel)
@@ -104,23 +85,13 @@ static int s6e3fa7_panel_disable(struct drm_panel *panel) 
{

	struct s6e3fa7_panel *ctx = to_s6e3fa7_panel(panel);

	struct mipi_dsi_device *dsi = ctx->dsi;

	struct device *dev = &dsi->dev;

	int ret;

	struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };



	ret = mipi_dsi_dcs_set_display_off(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to set display off: %d\n", ret);

		return ret;

	}

	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);

	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);

	mipi_dsi_msleep(&dsi_ctx, 120);



	ret = mipi_dsi_dcs_enter_sleep_mode(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to enter sleep mode: %d\n", ret);

		return ret;

	}

	msleep(120);



	return 0;

	return dsi_ctx.accum_err;

}



static const struct drm_display_mode s6e3fa7_panel_mode = {