Commit f32e8c80 authored by Mario Limonciello's avatar Mario Limonciello Committed by Jiri Kosina
Browse files

HID: amd_sfh: Avoid clearing reports for SRA sensor 



SRA sensor doesn't allocate any memory for reports.  Skip
trying to clear memory for that sensor in cleanup path.

Suggested-by: default avatarBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Acked-by: default avatarBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 0cc2effb

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c

+5 −0
Original line number Diff line number Diff line
@@ -83,6 +83,9 @@ static int amd_sfh_hid_client_deinit(struct amd_mp2_dev *privdata) 
		case ALS_IDX:

			privdata->dev_en.is_als_present = false;

			break;

		case SRA_IDX:

			privdata->dev_en.is_sra_present = false;

			break;

		}



		if (cl_data->sensor_sts[i] == SENSOR_ENABLED) {
@@ -237,6 +240,8 @@ static int amd_sfh1_1_hid_client_init(struct amd_mp2_dev *privdata) 
cleanup:

	amd_sfh_hid_client_deinit(privdata);

	for (i = 0; i < cl_data->num_hid_devices; i++) {

		if (cl_data->sensor_idx[i] == SRA_IDX)

			continue;

		devm_kfree(dev, cl_data->feature_report[i]);

		devm_kfree(dev, in_data->input_report[i]);

		devm_kfree(dev, cl_data->report_descr[i]);