Unverified Commit f3795233 authored by Lucas Stach's avatar Lucas Stach Committed by Robert Foss
Browse files

drm/bridge: analogix_dp: handle clock via runtime PM 



There is no reason to enable the controller clock in driver probe, as
there is no HW initialization done in this function. Instead rely on
either runtime PM to handle the controller clock or statically enable
it in the driver bind routine, after which real hardware access is
required to work.

Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Reviewed-by: default avatarRobert Foss <rfoss@kernel.org>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240619182200.3752465-4-l.stach@pengutronix.de
parent 2d192f4a

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

+44 −33
Original line number Diff line number Diff line
@@ -1651,8 +1651,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) 
		return ERR_CAST(dp->clock);

	}



	clk_prepare_enable(dp->clock);



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);



	dp->reg_base = devm_ioremap_resource(&pdev->dev, res);
@@ -1714,6 +1712,28 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) 
}

EXPORT_SYMBOL_GPL(analogix_dp_probe);



int analogix_dp_suspend(struct analogix_dp_device *dp)

{

	clk_disable_unprepare(dp->clock);



	return 0;

}

EXPORT_SYMBOL_GPL(analogix_dp_suspend);



int analogix_dp_resume(struct analogix_dp_device *dp)

{

	int ret;



	ret = clk_prepare_enable(dp->clock);

	if (ret < 0) {

		DRM_ERROR("Failed to prepare_enable the clock clk [%d]\n", ret);

		return ret;

	}



	return 0;

}

EXPORT_SYMBOL_GPL(analogix_dp_resume);



int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev)

{

	int ret;
@@ -1721,9 +1741,15 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev) 
	dp->drm_dev = drm_dev;

	dp->encoder = dp->plat_data->encoder;



	if (IS_ENABLED(CONFIG_PM)) {

		pm_runtime_use_autosuspend(dp->dev);

		pm_runtime_set_autosuspend_delay(dp->dev, 100);

		pm_runtime_enable(dp->dev);

	} else {

		ret = analogix_dp_resume(dp);

		if (ret)

			return ret;

	}



	dp->aux.name = "DP-AUX";

	dp->aux.transfer = analogix_dpaux_transfer;
@@ -1747,8 +1773,12 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev) 
err_unregister_aux:

	drm_dp_aux_unregister(&dp->aux);

err_disable_pm_runtime:

	if (IS_ENABLED(CONFIG_PM)) {

		pm_runtime_dont_use_autosuspend(dp->dev);

		pm_runtime_disable(dp->dev);

	} else {

		analogix_dp_suspend(dp);

	}



	return ret;

}
@@ -1765,40 +1795,21 @@ void analogix_dp_unbind(struct analogix_dp_device *dp) 
	}



	drm_dp_aux_unregister(&dp->aux);



	if (IS_ENABLED(CONFIG_PM)) {

		pm_runtime_dont_use_autosuspend(dp->dev);

		pm_runtime_disable(dp->dev);

	} else {

		analogix_dp_suspend(dp);

	}

}

EXPORT_SYMBOL_GPL(analogix_dp_unbind);



void analogix_dp_remove(struct analogix_dp_device *dp)

{

	clk_disable_unprepare(dp->clock);

}

EXPORT_SYMBOL_GPL(analogix_dp_remove);



#ifdef CONFIG_PM

int analogix_dp_suspend(struct analogix_dp_device *dp)

{

	clk_disable_unprepare(dp->clock);

	return 0;

}

EXPORT_SYMBOL_GPL(analogix_dp_suspend);



int analogix_dp_resume(struct analogix_dp_device *dp)

{

	int ret;



	ret = clk_prepare_enable(dp->clock);

	if (ret < 0) {

		DRM_ERROR("Failed to prepare_enable the clock clk [%d]\n", ret);

		return ret;

	}



	return 0;

}

EXPORT_SYMBOL_GPL(analogix_dp_resume);

#endif



int analogix_dp_start_crc(struct drm_connector *connector)

{

	struct analogix_dp_device *dp = to_dp(connector);