Commit f38ba545 authored by Konrad Dybcio's avatar Konrad Dybcio Committed by Greg Kroah-Hartman
Browse files

spmi: pmic-arb: Pass the correct of_node to irq_domain_add_tree 



Currently, irqchips for all of the subnodes (which represent a given
bus master) point to the parent wrapper node. This is no bueno, as
no interrupts arrive, ever (because nothing references that node).

Fix that by passing a reference to the respective master's of_node.

Worth noting, this is a NOP for devices with only a single master
described.

Signed-off-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20240522-topic-spmi_multi_master_irqfix-v2-1-7ec92a862b9f@linaro.org


Reviewed-by: default avatarAbel Vesa <abel.vesa@linaro.org>
Tested-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 02922ccb ("spmi: pmic-arb: Register controller for bus instead of arbiter")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20240725164636.3362690-3-sboyd@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2c10a20f

drivers/spmi/spmi-pmic-arb.c

+1 −2
Original line number Diff line number Diff line
@@ -1737,8 +1737,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev, 


	dev_dbg(&pdev->dev, "adding irq domain for bus %d\n", bus_index);



	bus->domain = irq_domain_add_tree(dev->of_node,

					  &pmic_arb_irq_domain_ops, bus);

	bus->domain = irq_domain_add_tree(node, &pmic_arb_irq_domain_ops, bus);

	if (!bus->domain) {

		dev_err(&pdev->dev, "unable to create irq_domain\n");

		return -ENOMEM;