Commit f3aec2ad authored by Tejun Heo's avatar Tejun Heo
Browse files

sched_ext: Add SCX_EFLAG_INITIALIZED to indicate successful ops.init() 



ops.exit() may be called even if the loading failed before ops.init()
finishes successfully. This is because ops.exit() allows rich exit info
communication. Add SCX_EFLAG_INITIALIZED flag to scx_exit_info.flags to
indicate whether ops.init() finished successfully.

This enables BPF schedulers to distinguish between exit scenarios and
handle cleanup appropriately based on initialization state.

Acked-by: default avatarAndrea Righi <arighi@nvidia.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent c7e73974

kernel/sched/ext.c

+1 −0
Original line number Diff line number Diff line
@@ -4554,6 +4554,7 @@ static int scx_enable(struct sched_ext_ops *ops, struct bpf_link *link) 
			scx_error(sch, "ops.init() failed (%d)", ret);

			goto err_disable;

		}

		sch->exit_info->flags |= SCX_EFLAG_INITIALIZED;

	}



	for (i = SCX_OPI_CPU_HOTPLUG_BEGIN; i < SCX_OPI_CPU_HOTPLUG_END; i++)

kernel/sched/ext_internal.h

+13 −0
Original line number Diff line number Diff line
@@ -62,6 +62,16 @@ enum scx_exit_code { 
	SCX_ECODE_ACT_RESTART	= 1LLU << 48,

};



enum scx_exit_flags {

	/*

	 * ops.exit() may be called even if the loading failed before ops.init()

	 * finishes successfully. This is because ops.exit() allows rich exit

	 * info communication. The following flag indicates whether ops.init()

	 * finished successfully.

	 */

	SCX_EFLAG_INITIALIZED,

};



/*

 * scx_exit_info is passed to ops.exit() to describe why the BPF scheduler is

 * being disabled.
@@ -73,6 +83,9 @@ struct scx_exit_info { 
	/* exit code if gracefully exiting */

	s64			exit_code;



	/* %SCX_EFLAG_* */

	u64			flags;



	/* textual representation of the above */

	const char		*reason;