Commit f3b566d7 authored by Chen Ridong's avatar Chen Ridong Committed by Andrew Morton
Browse files

memcg: remove inc/dec_lruvec_kmem_state helpers 

The dec_lruvec_kmem_state helper is unused by any caller and can be safely
removed.  Meanwhile, the inc_lruvec_kmem_state helper is only referenced
by shadow_lru_isolate, retaining these two helpers is unnecessary.  This
patch removes both helper functions to eliminate redundant code.

Link: https://lkml.kernel.org/r/20251126020435.1511637-1-chenridong@huaweicloud.com


Signed-off-by: default avatarChen Ridong <chenridong@huawei.com>
Acked-by: default avatarQi Zheng <zhengqi.arch@bytedance.com>
Acked-by: default avatarShakeel Butt <shakeel.butt@linux.dev>
Cc: Axel Rasmussen <axelrasmussen@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Lu Jialin <lujialin4@huawei.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Wei Xu <weixugc@google.com>
Cc: Yuanchu Xie <yuanchu@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 0384c8ea

include/linux/memcontrol.h

+0 −10
Original line number Diff line number Diff line
@@ -1452,16 +1452,6 @@ struct slabobj_ext { 
#endif

} __aligned(8);



static inline void inc_lruvec_kmem_state(void *p, enum node_stat_item idx)

{

	mod_lruvec_kmem_state(p, idx, 1);

}



static inline void dec_lruvec_kmem_state(void *p, enum node_stat_item idx)

{

	mod_lruvec_kmem_state(p, idx, -1);

}



static inline struct lruvec *parent_lruvec(struct lruvec *lruvec)

{

	struct mem_cgroup *memcg;

mm/workingset.c

+1 −1
Original line number Diff line number Diff line
@@ -749,7 +749,7 @@ static enum lru_status shadow_lru_isolate(struct list_head *item, 
	if (WARN_ON_ONCE(node->count != node->nr_values))

		goto out_invalid;

	xa_delete_node(node, workingset_update_node);

	inc_lruvec_kmem_state(node, WORKINGSET_NODERECLAIM);

	mod_lruvec_kmem_state(node, WORKINGSET_NODERECLAIM, 1);



out_invalid:

	xa_unlock_irq(&mapping->i_pages);