Commit f3dc4d98 authored by Thorsten Blum's avatar Thorsten Blum Committed by Miquel Raynal
Browse files

mtd: sm_ftl: Replace deprecated strncpy with sysfs_emit in sm_attr_show 

strncpy() is deprecated [1] for NUL-terminated destination buffers
because it does not guarantee NUL termination. It also unnecessarily
NUL-pads the destination buffer if the source is shorter. Replace it
with sysfs_emit() using the "%.*s" format specifier and supply the
length 'sm_attr->len' to improve sm_attr_show().

Return the number of characters actually written to 'buf' instead of
'sm_attr->len'.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings

 [1]
Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent c909fec6

drivers/mtd/sm_ftl.c

+1 −2
Original line number Diff line number Diff line
@@ -44,8 +44,7 @@ static ssize_t sm_attr_show(struct device *dev, struct device_attribute *attr, 
	struct sm_sysfs_attribute *sm_attr =

		container_of(attr, struct sm_sysfs_attribute, dev_attr);



	strncpy(buf, sm_attr->data, sm_attr->len);

	return sm_attr->len;

	return sysfs_emit(buf, "%.*s", sm_attr->len, sm_attr->data);

}