Commit f3ef7110 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Catalin Marinas
Browse files

ACPI/IORT: Fix memory leak in iort_rmr_alloc_sids() 



If krealloc_array() fails in iort_rmr_alloc_sids(), the function returns
NULL but does not free the original 'sids' allocation. This results in a
memory leak since the caller overwrites the original pointer with the
NULL return value.

Fixes: 491cf4a6 ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions")
Cc: <stable@vger.kernel.org> # 6.0.x
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarHanjun Guo <guohanjun@huawei.com>
Link: https://lore.kernel.org/r/20250828112243.61460-1-linmq006@gmail.com


Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 9a6d3ff1

drivers/acpi/arm64/iort.c

+3 −1
Original line number Diff line number Diff line
@@ -937,8 +937,10 @@ static u32 *iort_rmr_alloc_sids(u32 *sids, u32 count, u32 id_start, 


	new_sids = krealloc_array(sids, count + new_count,

				  sizeof(*new_sids), GFP_KERNEL);

	if (!new_sids)

	if (!new_sids) {

		kfree(sids);

		return NULL;

	}



	for (i = count; i < total_count; i++)

		new_sids[i] = id_start++;