Commit f3fd7f6f authored by Darrick J. Wong's avatar Darrick J. Wong
Browse files

xfs: hoist ->create_intent boilerplate to its callsite 



Hoist the dirty flag setting code out of each ->create_intent
implementation up to the callsite to reduce boilerplate further.

Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
parent e6e5299f

fs/xfs/libxfs/xfs_defer.c

+2 −0
Original line number Diff line number Diff line
@@ -240,6 +240,8 @@ xfs_defer_create_intent( 
	if (IS_ERR(lip))

		return PTR_ERR(lip);



	tp->t_flags |= XFS_TRANS_DIRTY;

	set_bit(XFS_LI_DIRTY, &lip->li_flags);

	dfp->dfp_intent = lip;

	return 1;

}

fs/xfs/xfs_attr_item.c

+0 −3
Original line number Diff line number Diff line
@@ -319,9 +319,6 @@ xfs_attr_log_item( 
{

	struct xfs_attri_log_format	*attrp;



	tp->t_flags |= XFS_TRANS_DIRTY;

	set_bit(XFS_LI_DIRTY, &attrip->attri_item.li_flags);



	/*

	 * At this point the xfs_attr_intent has been constructed, and we've

	 * created the log intent. Fill in the attri log item and log format

fs/xfs/xfs_bmap_item.c

+0 −3
Original line number Diff line number Diff line
@@ -286,9 +286,6 @@ xfs_bmap_update_log_item( 
	uint				next_extent;

	struct xfs_map_extent		*map;



	tp->t_flags |= XFS_TRANS_DIRTY;

	set_bit(XFS_LI_DIRTY, &buip->bui_item.li_flags);



	/*

	 * atomic_inc_return gives us the value after the increment;

	 * we want to use it as an array index so we need to subtract 1 from

fs/xfs/xfs_extfree_item.c

+0 −3
Original line number Diff line number Diff line
@@ -390,9 +390,6 @@ xfs_extent_free_log_item( 
	uint				next_extent;

	struct xfs_extent		*extp;



	tp->t_flags |= XFS_TRANS_DIRTY;

	set_bit(XFS_LI_DIRTY, &efip->efi_item.li_flags);



	/*

	 * atomic_inc_return gives us the value after the increment;

	 * we want to use it as an array index so we need to subtract 1 from

fs/xfs/xfs_refcount_item.c

+0 −3
Original line number Diff line number Diff line
@@ -289,9 +289,6 @@ xfs_refcount_update_log_item( 
	uint				next_extent;

	struct xfs_phys_extent		*pmap;



	tp->t_flags |= XFS_TRANS_DIRTY;

	set_bit(XFS_LI_DIRTY, &cuip->cui_item.li_flags);



	/*

	 * atomic_inc_return gives us the value after the increment;

	 * we want to use it as an array index so we need to subtract 1 from