Commit f42033b5 authored by Haotian Zhang's avatar Haotian Zhang Committed by Lee Jones
Browse files

leds: qcom-lpg: Check the return value of regmap_bulk_write() 



The lpg_lut_store() function currently ignores the return value of
regmap_bulk_write() and always returns 0. This can cause hardware write
failures to go undetected, leading the caller to believe LUT programming
succeeded when it may have failed.

Check the return value of regmap_bulk_write() in lpg_lut_store and return
the error to the caller on failure.

Fixes: 24e2d05d ("leds: Add driver for Qualcomm LPG")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20260108175133.638-1-vulab@iscas.ac.cn


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent ec924cd7

drivers/leds/rgb/leds-qcom-lpg.c

+5 −3
Original line number Diff line number Diff line
@@ -369,7 +369,7 @@ static int lpg_lut_store(struct lpg *lpg, struct led_pattern *pattern, 
{

	unsigned int idx;

	u16 val;

	int i;

	int i, ret;



	idx = bitmap_find_next_zero_area(lpg->lut_bitmap, lpg->lut_size,

					 0, len, 0);
@@ -379,8 +379,10 @@ static int lpg_lut_store(struct lpg *lpg, struct led_pattern *pattern, 
	for (i = 0; i < len; i++) {

		val = pattern[i].brightness;



		regmap_bulk_write(lpg->map, lpg->lut_base + LPG_LUT_REG(idx + i),

		ret = regmap_bulk_write(lpg->map, lpg->lut_base + LPG_LUT_REG(idx + i),

					&val, sizeof(val));

		if (ret)

			return ret;

	}



	bitmap_set(lpg->lut_bitmap, idx, len);