Commit f45b83ad authored by Junxian Huang's avatar Junxian Huang Committed by Leon Romanovsky
Browse files

RDMA/hns: Fix inappropriate err code for unsupported operations 



EOPNOTSUPP is more situable than EINVAL for allocating XRCD while XRC
is not supported and unsupported resizing SRQ.

Fixes: 32548870 ("RDMA/hns: Add support for XRC on HIP09")
Fixes: 221109e6 ("RDMA/hns: Add interception for resizing SRQs")
Signed-off-by: default avatarJunxian Huang <huangjunxian6@hisilicon.com>
Link: https://lore.kernel.org/r/20231114123449.1106162-2-huangjunxian6@hisilicon.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 79844118

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+1 −1
Original line number Diff line number Diff line
@@ -5666,7 +5666,7 @@ static int hns_roce_v2_modify_srq(struct ib_srq *ibsrq, 


	/* Resizing SRQs is not supported yet */

	if (srq_attr_mask & IB_SRQ_MAX_WR)

		return -EINVAL;

		return -EOPNOTSUPP;



	if (srq_attr_mask & IB_SRQ_LIMIT) {

		if (srq_attr->srq_limit > srq->wqe_cnt)

drivers/infiniband/hw/hns/hns_roce_pd.c

+1 −1
Original line number Diff line number Diff line
@@ -150,7 +150,7 @@ int hns_roce_alloc_xrcd(struct ib_xrcd *ib_xrcd, struct ib_udata *udata) 
	int ret;



	if (!(hr_dev->caps.flags & HNS_ROCE_CAP_FLAG_XRC))

		return -EINVAL;

		return -EOPNOTSUPP;



	ret = hns_roce_xrcd_alloc(hr_dev, &xrcd->xrcdn);

	if (ret)